Skip to content

refactor: invert swap fromToken and fromChain dependency #38414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

refactor: invert swap fromToken and fromChain dependency #38414

wants to merge 10 commits into from
+315 −285

Conversation

@micaelae
Copy link
Member

@micaelae micaelae commented Nov 28, 2025 •
edited by github-actions bot
Loading

Description

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Nov 28, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 28, 2025 •
edited
Loading

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers (18 files, +297 -284)
  • 📁 test/
    • 📁 data/
      • 📁 bridge/
        • 📄 mock-bridge-store.ts +57 -1
  • 📁 ui/
    • 📁 ducks/
      • 📁 bridge/
        • 📄 actions.ts +49 -64
        • 📄 bridge.ts +23 -23
        • 📄 selectors.test.ts +29 -4
        • 📄 selectors.ts +44 -32
        • 📄 types.ts +1 -1
        • 📄 utils.ts +14 -21
    • 📁 hooks/
      • 📁 bridge/
        • 📁 __snapshots__/
          • 📄 useBridgeQueryParams.test.ts.snap +2 -17
          • 📄 useBridgeExchangeRates.ts +2 -7
          • 📄 useBridgeQueryParams.test.ts +27 -3
          • 📄 useBridgeQueryParams.ts +17 -57
          • 📄 useBridging.test.ts +1 -1
          • 📄 useTokenAlerts.test.ts +2 -0
    • 📁 pages/
      • 📁 bridge/
        • 📁 prepare/
          • 📁 components/
            • 📄 bridge-asset-picker-button.tsx +9 -6
            • 📄 bridge-input-group.tsx +1 -2
            • 📄 prepare-bridge-page.tsx +13 -44
        • 📁 utils/
          • 📄 quote.ts +1 -1
          • 📄 slippage-service.test.ts +5 -0

@micaelae micaelae force-pushed the swaps-simplify-network-list branch 2 times, most recently from dc5c556 to 9968444 Compare December 1, 2025 21:05
@github-actions github-actions bot added size-XL and removed size-L labels Dec 1, 2025
@micaelae micaelae force-pushed the swaps-simplify-network-list branch from 150e60f to f36aab3 Compare December 1, 2025 21:21
@github-actions github-actions bot added size-L and removed size-XL labels Dec 1, 2025
@micaelae micaelae force-pushed the swaps-simplify-network-list branch from d0be115 to 5a33323 Compare December 3, 2025 18:30
@metamaskbot
Copy link
Collaborator

metamaskbot commented Dec 3, 2025

Builds ready [5a33323]
UI Startup Metrics (1324 ± 108 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup13241099155210814071494
load109891213359711551262
domContentLoaded109290813189511461253
domInteractive2917172262393
firstPaint52488133042510701256
backgroundConnect23320029513239256
firstReactRender3622138153957
getState4317230275178
initialActions109215
loadScripts8656881111949201028
setupStore1483261627
numNetworkReqs1157117561
BrowserifyPower User HomeuiStartup20461657296425222192466
load1023889178913810601325
domContentLoaded1013881177513810511320
domInteractive3017125182979
firstPaint52010117904029391260
backgroundConnect271204783132233619
firstReactRender53409095671
getState19714570175210264
initialActions104112
loadScripts80167715461348341103
setupStore1574261532
numNetworkReqs79612312874144
WebpackStandard HomeuiStartup785665107181806965
load60854583665631774
domContentLoaded60354183165627769
domInteractive2414102201985
firstPaint22292794147202610
backgroundConnect116106111225
firstReactRender2819138133238
getState261279133250
initialActions104111
loadScripts60153982364625767
setupStore1052231117
numNetworkReqs1056915560
WebpackPower User HomeuiStartup16101258216425518612114
load684584115397707896
domContentLoaded676578114897698889
domInteractive33181342631108
firstPaint276114883194262743
backgroundConnect82860416526536
firstReactRender594594106480
getState18514466554188247
initialActions104112
loadScripts673576114096696881
setupStore17962111545
numNetworkReqs79632342774148
FirefoxBrowserifyStandard HomeuiStartup12561061178313313361472
load104792114068511001211
domContentLoaded104792014068511001210
domInteractive58311793483121
firstPaint------
backgroundConnect44201572743109
firstReactRender22183742334
getState146151201052
initialActions102122
loadScripts102190613057610731147
setupStore1057781020
numNetworkReqs1156416662
BrowserifyPower User HomeuiStartup29901997505888738894568
load1349933272249513092493
domContentLoaded1349933272249513092493
domInteractive10332983108109257
firstPaint------
backgroundConnect2912612193833561166
firstReactRender61342843462130
getState353701941348536965
initialActions203123
loadScripts1181915252831811842157
setupStore1185849180108616
numNetworkReqs76551352074122
WebpackStandard HomeuiStartup14441228183514415571715
load12041045146411112951416
domContentLoaded12041045146311012941416
domInteractive58261983980152
firstPaint------
backgroundConnect4320176254394
firstReactRender25197772633
getState136157181144
initialActions102012
loadScripts11791029143810412591383
setupStore1157391131
numNetworkReqs1156416663
WebpackPower User HomeuiStartup32912468488378142194661
load16291170309750515862799
domContentLoaded16291170309650515862798
domInteractive1003138971109280
firstPaint------
backgroundConnect2612911973263411166
firstReactRender65411932768129
getState336921242287500931
initialActions609616325
loadScripts14941141293636315222467
setupStore1017100916487492
numNetworkReqs875721437103179
📊 Page Load Benchmark Results

Current Commit: 5a33323 | Date: 12/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±38ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 724ms (±36ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 38ms 1.01s 1.31s 1.07s 1.31s
domContentLoaded 724ms 36ms 699ms 980ms 749ms 980ms
firstPaint 77ms 12ms 60ms 172ms 88ms 172ms
firstContentfulPaint 77ms 12ms 60ms 172ms 88ms 172ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 124 Bytes (0%)
  • ui: -1.56 KiB (-0.02%)
  • common: 423 Bytes (0%)

@micaelae micaelae closed this Dec 4, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

size-L team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@micaelae @metamaskbot